do not try another peer on a local error #440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🤖 Claude Code Review Status: Complete Current Review: Found a format string bug in 4 error messages (lines 572, 578, 609, 620) where each has one History:
|
icellan
requested changes
Jan 28, 2026
| // Local errors include context cancellation, semaphore exhaustion, and storage errors | ||
| // that are caused by local resource constraints rather than peer failures. | ||
| // These errors should not trigger peer failover since trying another peer won't help. | ||
| func isLocalError(err error) bool { |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| // Check if error is local (not peer-related) - don't retry with other peers | ||
| if errors.IsLocalError(err) { | ||
| return errors.NewServiceError("[catchup:fetchAndStoreSubtreeAndSubtreeData] Local error fetching subtreeData for %s (not retrying with other peers)", subtreeHash.String(), err) |
Contributor
There was a problem hiding this comment.
Format string bug: has one %s placeholder but passes two arguments (hash and err). The error will be ignored. Need to add %v placeholder for the error.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running teratestnet and syncing, I could semaphore errors. blockvalidation was deciding the problem was with the peer and started over with a new peer. The problem in this instance was in my own teranode so it shouldn't pick another peer and possible downgrade the 'bad' peer.